The treaty has inherent flaws, another treaty or amendments are necessary to achieve a real ban
The problem is that the treaties are ambiguous, despite claims that they aren’t, neither the NPT or this new one functions as a comprehensive nuclear weapons convention. As a result the legality of Nuclear weapons remains elusive and the problem remains unsolved. The lack of voting UN members is another issue, if all nuclear powers and NATO abstain from voting, it is likely that some may also challenge an effective ban treaty outright. This new treaty may successfully stigmatise states with nuclear weapons, but it will take great strides in diplomacy and defence to get to a treaty that prohibits these weapons entirely.